Added support for overridding the Liveness Probe Timeout#26
Open
jordanTunstill wants to merge 1 commit intomainfrom
Open
Added support for overridding the Liveness Probe Timeout#26jordanTunstill wants to merge 1 commit intomainfrom
jordanTunstill wants to merge 1 commit intomainfrom
Conversation
github-actions
Bot
added
size/XS
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A customer asked for us to add support for them to override the LivenessProbeTimeout with a customized value. This PR does that.
Note
Low Risk
Low risk: adds a new Helm value wired into the Kubernetes
livenessProbe.timeoutSecondsfield; main impact is potentially changing pod restart behavior if misconfigured.Overview
Adds support for configuring the Kubernetes liveness probe timeout via Helm values.
The deployment template now sets
livenessProbe.timeoutSecondsfrom.Values.probe.timeoutSeconds, and the chartvalues.yaml+values.schema.jsondefine this newprobe.timeoutSecondsvalue (default1) and require it during values validation.Reviewed by Cursor Bugbot for commit 3e69e2a. Bugbot is set up for automated code reviews on this repo. Configure here.