fix(ui): prevent media drawer thumbnails from eager preloading#16393
Open
mattiaz9 wants to merge 1 commit intopayloadcms:mainfrom
Open
fix(ui): prevent media drawer thumbnails from eager preloading#16393mattiaz9 wants to merge 1 commit intopayloadcms:mainfrom
mattiaz9 wants to merge 1 commit intopayloadcms:mainfrom
Conversation
Author
|
I just realized the version in main is v4-beta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
Updates thumbnail rendering to avoid eager image preloading and instead let the browser load thumbnails directly with
loading="lazy"/decoding="async". Also adds handling for cached images so thumbnails do not stay in a loading state when drawers are reopened.Why?
When selecting media with
cacheComponentsenabled, opening a media drawer with multiple preview thumbnails could trigger refresh/reload behavior and cause unsaved form changes to be lost. DisablingdisplayPreviewavoided the issue, pointing to thumbnail loading as the trigger.How?
Removes the manual
new Image()probe from the thumbnail component, renders the<img>directly, and tracks load/error state through the image element. Cached images are detected viacomplete/naturalWidthso reopening the drawer does not leave thumbnails showing an indefinite shimmer.Fixes #16270