feat(engine): add commit iteration support for pull request evaluation#6372
Open
sachin9058 wants to merge 2 commits intomindersec:mainfrom
Open
feat(engine): add commit iteration support for pull request evaluation#6372sachin9058 wants to merge 2 commits intomindersec:mainfrom
sachin9058 wants to merge 2 commits intomindersec:mainfrom
Conversation
Contributor
Author
|
Note: Observed a data race in TestNatsChannel related to NATS JetStream internals. This appears to be upstream and unrelated to the changes in this PR. |
Contributor
Author
|
@evankanderson This PR is intentionally scoped as a foundational step toward commit-level evaluation. It introduces commit iteration support across pull requests while keeping the existing behavior unchanged. This allows future enhancements such as commit-level policy checks (e.g., content, message format, metadata) to build on top of this without expanding the scope of this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces basic support for iterating over all commits in a pull request during evaluation.
Currently, Minder evaluates only the final (HEAD) state of a pull request. This change lays the groundwork for future commit-level policies by exposing commit data such as SHA and message across all commits in the PR.
The implementation:
This change is intentionally scoped to be foundational and does not introduce any policy enforcement yet.
Fixes #2176
Testing
go test ./...