feat: add interactive 'minder profile edit' command#6355
Open
DharunMR wants to merge 1 commit intomindersec:mainfrom
Open
feat: add interactive 'minder profile edit' command#6355DharunMR wants to merge 1 commit intomindersec:mainfrom
DharunMR wants to merge 1 commit intomindersec:mainfrom
Conversation
DharunMR
force-pushed
the
feat-minder-profile
branch
from
58fc5b5 to
65dc745
Compare
|
Coverage is 60.194% — DharunMR:feat-minder-profile into mindersec:main. No base build found for |
Member
evankanderson
left a comment
evankanderson
left a comment
There was a problem hiding this comment.
A few comments; I'd merge this except that I think the handling of $EDITOR is probably wrong (should not be space-split).
Comment on lines
+150
to
+157
| updatedJSON, err := yaml.YAMLToJSON(updatedBytes) | ||
| if err != nil { | ||
| return cli.MessageAndError("Error parsing updated YAML", err) | ||
| } | ||
| um := protojson.UnmarshalOptions{DiscardUnknown: true} | ||
| if err := um.Unmarshal(updatedJSON, &updatedProfile); err != nil { | ||
| return cli.MessageAndError("Error loading updated profile data into protobuf", err) | ||
| } |
Member
There was a problem hiding this comment.
You may want to use minderv1.ParseResource to convert YAML to a protobuf.
Contributor
Author
There was a problem hiding this comment.
my only concern is GetProfile API response drops the type and version fields so i had to manually inject them into the struct before generating the yaml so ParseResource wouldnt fail validation.
DharunMR
force-pushed
the
feat-minder-profile
branch
from
65dc745 to
b655a78
Compare
Signed-off-by: DharunMR <maddharun56@gmail.com>
DharunMR
force-pushed
the
feat-minder-profile
branch
from
b655a78 to
4383402
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces the minder profile edit command, allowing users to fetch a profile, modify it in their local text editor, and apply changes in a single interactive workflow.
Implemented a robust lookup system that checks $VISUAL -> $EDITOR -> system path (searching for nano, vim, nvim, vi, or emacs) using exec.LookPath.
The implementation ensures that critical fields such as Id, Context, Type, and Version are preserved from the original fetch. This prevents validation errors if the user accidentally deletes these fields during the editing session.
Before
After
