ServiceFabricDeployV1: emit SfSafeParserFailure telemetry on safe-parser errors#22069
Open
ServiceFabricDeployV1: emit SfSafeParserFailure telemetry on safe-parser errors#22069
Conversation
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
2 similar comments
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
tpavlovi
force-pushed
the
users/tpavlovi/sf-safe-parser-telemetry
branch
from
cd33f2c to
6cccf9d
Compare
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
Contributor
Author
|
/azp run |
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
AB#2378793
Task Name
ServiceFabricDeployV1
Description
SfSafeParserFailuretoTasks/Common/ServiceFabricHelpers/SFOperations.ps1.Publish-UpgradedServiceFabricApplication.ps1, set$global:operationId = $SF_Operations.SfSafeParserFailureimmediately before invokingConvertTo-ServiceTypeHealthPolicyMap, so any exception thrown by the safe parser is reported via the existingPublish-Telemetrycall indeploy.ps1's catch block with a distinctOperationId.Risk Assessment (Low / Medium / High)
Low
Change Behind Feature Flag (Yes / No)
Yes (
DistributedTask.Tasks.SfSafeParser)Tech Design / Approach
Documentation Changes Required (Yes/No)
No
Unit Tests Added or Updated (Yes / No)
No
Additional Testing Performed
Logging Added/Updated (Yes/No)
No
Telemetry Added/Updated (Yes/No)
No
Rollback Scenario and Process (Yes/No)
Disable the
DistributedTask.Tasks.SfSafeParserpipeline feature flagDependency Impact Assessed and Regression Tested (Yes/No)
Checklist