Resolve vulnerabilities in root project#1368
Merged
ivanduplenskikh merged 5 commits intomasterfrom Apr 28, 2026
Merged
Conversation
- bump azure-pipelines-task-lib from ^5.2.8 to ^5.2.10 - upgrade gulp from ^4.0.2 to ^5.0.1 - upgrade gulp-mocha from ^6.0.0 to ^10.0.1 - update gulp-util from ^3.0.7 to ^1.0.0 - upgrade xml2js from ^0.4.17 to ^0.6.2 - update yargs from ^4.7.1 to ^18.0.0 - change qs version from 6.14.1 to ^6.14.2 in overrides - add serialize-javascript with version ^7.0.5 in overrides
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
starkmsu
approved these changes
Apr 28, 2026
manolerazvan
approved these changes
Apr 28, 2026
|
Azure Pipelines: Successfully started running 1 pipeline(s). |
manolerazvan
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description: Resolve
npm auditvulnerabilities in the rootpackage.jsonand fix the build-tooling fallout exposed by the upgrades.Dependency changes (root
package.json)gulp-mocha^7.0.2→^10.0.1— clears themocha→debug/diff/js-yaml/minimatchadvisory chain (incl. high-severity minimatch ReDoS).qsoverride6.14.1→^6.14.2— clears GHSA-w7fw-mjwx-w883 (the previous override was still inside the vulnerable range).serialize-javascript^7.0.5override — clears the high-severityserialize-javascriptRCE/DoS advisories pulled in transitively viamocha@10.gulp-utiland@types/gulp-util— the package is deprecated and pulled in vulnerablelodash.template(high-severity command injection). All call sites replaced with stdlib equivalents.package-lock.jsonregenerated.Code changes
gulpfile.js:yargsinitialization to the v18-compatible API (require('yargs')(hideBin(process.argv)).argv). The legacy singletonrequire('yargs').argvreturnsundefinedin yargs 18 and was breakinggulp buildin CI withCannot read properties of undefined (reading 'testAreaPath').require.resolve('mocha/package.json')instead of the hardcoded nestednode_modules/gulp-mocha/node_modules/mocha/bin/_mochapath; withgulp-mocha@10mocha is hoisted to the top-levelnode_modules.gutil.log(...)withconsole.log(...)andnew gutil.PluginError('compileTasks', msg)withnew Error('compileTasks: ' + msg).package.js:gulp-utilimport andcreateErrorhelper; replacegutil.PluginErrorconstructions with plainErrorandgutil.logwithconsole.log.Residual / known
uuid <14.0.0reached viaazure-pipelines-task-lib. There is no upstream fix (latestazure-pipelines-task-lib@5.2.10still depends onuuid@^3and uses theuuid/v4subpath import). The advisory only affectsv3/v5/v6when abufis provided; thev4random path used here is not affected. A globaluuidoverride is not viable because uuid v7+ removed subpath imports and would breakvault.js.Validation
npm installclean.npm audit: down from 10 vulns (2 high, 3 moderate, 5 low) to 1 known/accepted moderate (uuid).npm run buildexits 0 locally.Documentation changes required: N
Added unit tests: N
Attached related issue: N
Checklist: