Fix ECharts 6.0.0 incompatibility#560
Open
joshkel wants to merge 1 commit intoecomfe:masterfrom
Open
Conversation
Fixes ecomfe#556 This change is incompatible with ECharts pre 6.0.0.
65ca32d to
d694b96
Compare
|
Hi, can we proritise this PR? |
|
Hey, I would also like this PR merged. I tried this PR and ran into some issues described in lublak/typst-echarm-package#10 (comment) related to missing file extensions just a repeat of the error: As I am not a professional in JS I am not sure if this is really an issue or I am too dumb to use npm. But maybe worth considering before merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #556
This change is incompatible with ECharts pre 6.0.0.