[QUIC] Do not allocate exception if it might not be used#127526
Open
ManickaP wants to merge 1 commit intodotnet:mainfrom
Open
[QUIC] Do not allocate exception if it might not be used#127526ManickaP wants to merge 1 commit intodotnet:mainfrom
ManickaP wants to merge 1 commit intodotnet:mainfrom
Conversation
Contributor
|
Tagging subscribers to this area: @karelz, @dotnet/ncl |
MihaZupan
approved these changes
Apr 28, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Reduces avoidable allocations on the QUIC stream shutdown path by preventing creation of an OperationAborted QuicException when it cannot be observed (because the stream start task source is already completed). This aligns with the perf investigation in #127455 and targets the high-frequency shutdown event path for HTTP/3 server scenarios.
Changes:
- Guard
_startedTcs.TrySetException(ThrowHelper.GetOperationAbortedException())behind_startedTcs.IsCompletedto avoid allocating an exception that would be ignored. - Preserve existing shutdown completion semantics while reducing handled exception churn.
wfurt
approved these changes
Apr 28, 2026
ladeak
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #127455
Validation manual on the repro code, before:
after (no more
QuicException):