Exclude DeadThreads test from GC stress compatible set#127478
Open
Exclude DeadThreads test from GC stress compatible set#127478
Conversation
Agent-Logs-Url: https://github.com/dotnet/runtime/sessions/f577a0d4-d2ab-4236-b07f-dd4f7c745713 Co-authored-by: VSadov <8218165+VSadov@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix test failure in DeadThreads cmd execution
Exclude DeadThreads test from GC stress compatible set
Apr 27, 2026
Contributor
|
Tagging subscribers to this area: @JulieLeeMSFT, @VSadov |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR opts the DeadThreads test out of GC stress runs by marking it GC-stress incompatible, based on its very high thread-creation rate leading to OOM/excessive paging under GC stress.
Changes:
- Mark
DeadThreadsas GC stress incompatible via<GCStressIncompatible>true</GCStressIncompatible>. - Add a short explanatory comment clarifying why the test is excluded from GC stress.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
DeadThreadscreates threads at a very high rate, making it unsuitable for GC stress runs where frequent GCs slow execution enough to cause OOM or excessive paging.Changes
src/tests/baseservices/threading/DeadThreads/DeadThreads.csproj: Added<GCStressIncompatible>true</GCStressIncompatible>to opt the test out of GC stress (GCStress3/GCStressC) runs.AI Generated Content Notice
Note
This PR description was generated by GitHub Copilot.