Skip to content

feat(impersonation): allow to disable strict enforcement (#27084)#27573

Open
agaudreault wants to merge 6 commits intoargoproj:masterfrom
agaudreault:imp-global-enforce
Open

feat(impersonation): allow to disable strict enforcement (#27084)#27573
agaudreault wants to merge 6 commits intoargoproj:masterfrom
agaudreault:imp-global-enforce

Conversation

@agaudreault
Copy link
Copy Markdown
Member

@agaudreault agaudreault commented Apr 28, 2026

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • The title of the PR conforms to the Title of the PR
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).
  • My new feature complies with the feature status guidelines.
  • I have added a brief description of why this PR is necessary and/or what this PR solves.
  • Optional. My organization is added to USERS.md.
  • Optional. For bug fixes, I've indicated what older releases this fix should be cherry-picked into (this may or may not happen depending on risk/complexity).

@agaudreault agaudreault requested review from a team as code owners April 28, 2026 16:13
@bunnyshell
Copy link
Copy Markdown

bunnyshell Bot commented Apr 28, 2026

✅ Preview Environment deployed on Bunnyshell

Component Endpoints
argocd https://argocd-qlcrao.bunnyenv.com/
argocd-ttyd https://argocd-web-cli-qlcrao.bunnyenv.com/

See: Environment Details | Pipeline Logs

Available commands (reply to this comment):

  • 🔴 /bns:stop to stop the environment
  • 🚀 /bns:deploy to redeploy the environment
  • /bns:delete to remove the environment

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault enabled auto-merge (squash) April 28, 2026 16:49
@agaudreault agaudreault added the for-release-blog-3-5 PR that should be highlighted in the Release Blog label Apr 28, 2026
Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
Copy link
Copy Markdown
Member

@alexymantha alexymantha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: Alexandre Gaudreault <alexandre_gaudreault@intuit.com>
@agaudreault agaudreault added the ready-for-review An approver should give a final review and merge the PR label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 81.57895% with 7 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.53%. Comparing base (f71239c) to head (cbe51ab).

Files with missing lines Patch % Lines
controller/sync.go 73.68% 4 Missing and 1 partial ⚠️
server/application/application.go 81.81% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #27573   +/-   ##
=======================================
  Coverage   63.52%   63.53%           
=======================================
  Files         417      417           
  Lines       57054    57082   +28     
=======================================
+ Hits        36246    36269   +23     
- Misses      17410    17411    +1     
- Partials     3398     3402    +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

for-release-blog-3-5 PR that should be highlighted in the Release Blog ready-for-review An approver should give a final review and merge the PR

Projects

Status: Ready for final review

Development

Successfully merging this pull request may close these issues.

2 participants