fix(demo): switch adapter based on defines, add PICO_CYW43_SUPPORTED#868
Open
tyeth wants to merge 6 commits intomigrate-api-v2from
Open
fix(demo): switch adapter based on defines, add PICO_CYW43_SUPPORTED#868tyeth wants to merge 6 commits intomigrate-api-v2from
tyeth wants to merge 6 commits intomigrate-api-v2from
Conversation
Member
|
@tyeth Please add more information into this PR such as:
|
Member
Author
👍 Done |
tyeth
commented
Mar 24, 2026
Comment on lines
+471
to
+474
| -DARDUINO_ARCH_RP2350 | ||
| -I$PROJECT_PACKAGES_DIR/framework-arduinopico/pico-sdk/src/rp2350/hardware_structs/include | ||
| -I$PROJECT_PACKAGES_DIR/framework-arduinopico/pico-sdk/src/rp2350/hardware_regs/include | ||
| -I$PROJECT_PACKAGES_DIR/framework-arduinopico/pico-sdk/src/rp2_common/hardware_powman/include |
Member
Author
There was a problem hiding this comment.
we shouldn't be adding the arch define most likely, and instead rely on the BSP/earlePicoCore, although the includes were agreed to be needed for pio for now.
tyeth
commented
Mar 24, 2026
Comment on lines
+478
to
+482
| build_src_filter = | ||
| +<*> | ||
| +<../.pio/libdeps/raspberrypi_pico_2w/Adafruit SleepyDog Library/utility/WatchdogRP2350/*.cpp> | ||
| +<../.pio/libdeps/raspberrypi_pico_2w/Adafruit SleepyDog Library/utility/WatchdogRP2350/pico_sleep/*.c> | ||
| +<../.pio/libdeps/raspberrypi_pico_2w/Adafruit SleepyDog Library/utility/WatchdogRP2350/hardware_rosc/*.c> |
Member
Author
There was a problem hiding this comment.
The src filter to add rp2350 files looks to be a workaround for the compilation issue in sleepydog.
As a new PR has come in since to correct that, then @tyeth revisit this after it lands.
And RETEST!!!!
tyeth
force-pushed
the
add-sleep-mode-network-defines
branch
from
682fc6b to
39ccc29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently you cannot build using platformio offline mode for Wi-Fi and non Wi-Fi adapters without manually changing the code base.
This PR facilitates not having to do that by checking suitable network defines on Wi-Fi enabled boards, and then picking the WiFi or non WiFi adapter.
Found issue moving between Pico2w and metroRP2350 when testing the sleep mode PR.
The CYW43 included with pico and rm2 modules has a specific define that we can track too, so the network adaptor has been augmented with this.