Re-request Review does not work after a "Comment" Review (with line comment)

[JpMand]

Description

On a Pull Request with a Requested Review, if the reviewer submits a "Comment" Review (Not "Approve" or "Request Changes") with at least 1 line comment and all files are "viewed", then the button for the re-request review does not work anymore.

Clicking on it reloads the page but does not add the "Requested review" activity on the Conversation tab and does not mark the Reviewer with "Review pending".

My doubt if it's an expected thing, since it's not an request change or approval review, meaning the initial review request is still valid, but at least it should give a proper indication of it, instead of failing silently.

Reproduction Steps:

1. Author creates a normal Pull Request (with additional commits and file changed/added)
2. Author requests review from Reviewer
3. Reviewer Submit a "Comment" Review
   a. Must have at least 1 review comment in a line
   b. Must check as viewed all files
4. Author re-request review from Reviewer
   a. (Optional) Author pushes a change before re-requesting review.

Expected:
Pull Request Reviewers is updated with "Bob" marked with "Review Pending" and no button to re-request review

Result:
Pull Request Reviewers is updated, but with no changes, meaning no "Review Pending" and with re-request button still present.

• Submitting an Approve or Requests changes does not case the issue
• Making an "Comment" review with no file comments does not case the issue
• Making an "Comment" review with file comments but without checking all files as viewed, does not case the issue

Gitea Version

1.25.5

Can you reproduce the bug on the Gitea demo site?

Yes

Log Gist

https://gist.github.com/JpMand/0bbf3a54a256bbd55bc5314f14957efb

Screenshots

No response

Git Version

No response

Operating System

No response

How are you running Gitea?

I tested with:

• Local docker gitea (using docker-compose)
  • Tested initially with image docker.gitea.com/gitea:1.25.5, then with the image to docker.gitea.com/gitea:1.26.0 (same gitea folder)
• https://demo.gitea.com
• https://gitea.com

URL demo gitea: https://demo.gitea.com/JpMand/idea-plugin-demo-repo/pulls/2
URL gitea https://gitea.com/JpMand/testRepo

docker-compose file

version: "3"

networks:
  gitea:
    external: false

services:
  server:
    image: docker.gitea.com/gitea:1.25.5
    container_name: gitea
    environment:
      - USER_UID=1000
      - USER_GID=1000
    restart: always
    networks:
      - gitea
    volumes:
      - ./gitea:/data
    ports:
      - "3000:3000"
      - "222:22"

Database

None

[KalashThakare]

Hey @JpMand i tried reproducing same issue but everything working fine and no bug was reproduced.

also your version is old try reproducing it with newer gitea version.

It seems the issue is fixed in newer version.

[JpMand]

Hey @JpMand i tried reproducing same issue but everything working fine and no bug was reproduced.

also your version is old try reproducing it with newer gitea version.

It seems the issue is fixed in newer version.

Thanks for testing. As far I can test, the combination of "all files viewed", "at least one comment on a changed/added file", "submit as comment review" is the factor for recreating this state.

It is very particular, and for that reason I'm unsure if this could be a bug at all or simply missing clarification (about the fact that non "final" review does not close the review request, despite allowing to re-request).

As of note, in the Pull Request list page, the PR still has the "1 awaiting review" (but I guess it is expected since a "comment" review is not an actual review like "Approve" or "Request Changes")

As for the version, I specified first finding the issue with 1.25.5, but am still able to reproduce both in local docker 1.26.0 (and 1.26.1) and https://gitea.com (my PR example with this issue from the testRepo I referenced: https://gitea.com/JpMand/testRepo/pulls/2).

I haven't retried yet with https://demo.gitea.com since it has been 10 minutes the server is responding with 503 when attempting to open a PR

I've just updated my local docker gitea compose with docker.gitea.com/gitea:1.26.1 and retried it (with new repository and PR) and the "issue" is still present.

The steps I took were:

1. user1 creates repository with some files with user2 as collaborator (with default write).
2. user2 modifies one of the files and creates a Pull Request
3. user2 adds user1 as reviewer, requesting review
4. user1 submits a "comment" review:
   a. All files viewed
   b. One line comment
5. user2 attempts to re-request review from user1
   a. The expectation is that in reviewers list, user1 should have pending review, but instead nothing changes.
6. user2 modifies again the file
   a. In Reviewers list, user1 also has the hourglass icon indicating changes since last review.
7. user2 re-attempts to re-request review from user1
   a. Again, the expectation is that in reviewers list, user1 should have pending review, but instead nothing changes.

I added a new gist with app.ini and logs of the entire process (from startup after changing gitea image version to 1.26.1):

• url: https://gist.github.com/JpMand/e32a2a67a14ebbd8828f7de9ca3117e7

[KalashThakare]

Hey @JpMand i tried reproducing same issue but everything working fine and no bug was reproduced.
also your version is old try reproducing it with newer gitea version.
It seems the issue is fixed in newer version.

Thanks for testing. As far I can test, the combination of "all files viewed", "at least one comment on a changed/added file", "submit as comment review" is the factor for recreating this state.

It is very particular, and for that reason I'm unsure if this could be a bug at all or simply missing clarification (about the fact that non "final" review does not close the review request, despite allowing to re-request).

As of note, in the Pull Request list page, the PR still has the "1 awaiting review" (but I guess it is expected since a "comment" review is not an actual review like "Approve" or "Request Changes")

As for the version, I specified first finding the issue with 1.25.5, but am still able to reproduce both in local docker 1.26.0 (and 1.26.1) and https://gitea.com (my PR example with this issue from the testRepo I referenced: https://gitea.com/JpMand/testRepo/pulls/2).

I haven't retried yet with https://demo.gitea.com since it has been 10 minutes the server is responding with 503 when attempting to open a PR

I've just updated my local docker gitea compose with docker.gitea.com/gitea:1.26.1 and retried it (with new repository and PR) and the "issue" is still present.

The steps I took were:

1. user1 creates repository with some files with user2 as collaborator (with default write).
2. user2 modifies one of the files and creates a Pull Request
3. user2 adds user1 as reviewer, requesting review
4. user1 submits a "comment" review:
   a. All files viewed
   b. One line comment
5. user2 attempts to re-request review from user1
   a. The expectation is that in reviewers list, user1 should have pending review, but instead nothing changes.
6. user2 modifies again the file
   a. In Reviewers list, user1 also has the hourglass icon indicating changes since last review.
7. user2 re-attempts to re-request review from user1
   a. Again, the expectation is that in reviewers list, user1 should have pending review, but instead nothing changes.

I added a new gist with app.ini and logs of the entire process (from startup after changing gitea image version to 1.26.1):

• url: https://gist.github.com/JpMand/e32a2a67a14ebbd8828f7de9ca3117e7

fine i will try reproducing it again, also to clarify the whether this is a bug or not try understanding how github behaves with such thing.

[JpMand]

fine i will try reproducing it again, also to clarify the whether this is a bug or not try understanding how github behaves with such thing.

Sorry for asking you to redo it and thanks for accepting to do it.
If it's not reproducible for you and someone else also confirms it, then I'll consider this a matter of me not understanding how it should work or my browser perhaps causing some problems.

As for how Github behaves, from what I could read from the documentation and doing a test, the reviewer state changes to pending review (the orange dot) and re-request review button disappears. This behaviour is the same for all types of review (Comment, Approve or Request Changes), independently if there are changes since last review or not.